session with round tripper keep alive #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sagar Muchhal <[email protected]> (cherry picked from commit 19fe72c)
Updates kube-vip version to 0.3.2
jzhoucliqr
reviewed
Mar 26, 2021
pkg/manager/constants.go
Outdated
| @@ -29,6 +29,11 @@ const ( | |||
| // manager option. | |||
| DefaultSyncPeriod = time.Minute * 10 | |||
|
|
|||
| // DefaultEnableKeepAlive is false by default | |||
| DefaultEnableKeepAlive = false | |||
pkg/manager/constants.go
Outdated
| // DefaultEnableKeepAlive is false by default | ||
| DefaultEnableKeepAlive = false | ||
|
|
||
| DefaultKeepAliveDuration = time.Duration(0) |
pkg/session/session.go
Outdated
| if ok, _ := c.SessionManager.SessionIsActive(ctx.context); ok { | ||
| return nil | ||
| } | ||
| if err := c.Login(ctx.context, url.User); err != nil { |
There was a problem hiding this comment.
actually I don't know what is the behavior here. I guess we need to test it out. build a cluster and let it run for 2 days lets see.
Removes topology feature gate
- This patch updates the cluster-api dependency version to use the latest from the main branch. As a result, the controller-runtime version is also updates to v0.8.2 - This patch also updates the v1alpha3 refs in the codebase to v1alpha4. - It also updates golang version to 1.15 - Changes to incorporate nightly CAPI builds Signed-off-by: Sagar Muchhal <[email protected]>
Updates references to v1alpha4 types
- Sets up the controller test environment to test the CAPV controllers using the env.Environment - Adds a test for VSphereClusterController - Adds new CertDir parameter to the Manager Options used by the envtest for Webhook certs - Added a TODO to use the controller-runtime Options instead. Signed-off-by: Sagar Muchhal <[email protected]>
- Adds storage-policy flavour
- adds storage policy to haproxy flavour
sadysnaat
force-pushed
the
session-keepalive
branch
from
bf7032d to
cd63694
Compare
Adds storage policy to e2e tests
Reconcile storage policy after vm clone
Adds support for controller tests
Signed-off-by: Sagar Muchhal <[email protected]> Co-authored-by: Yassine TIJANI <[email protected]>
…rash Checks for length of network statuses while generating metadata
Signed-off-by: Sagar Muchhal <[email protected]> (cherry picked from commit 64a95bd)
Adds log statements to get/create session
- Also, updates the CAPI ref commit used as a package - Includes updates to controller-runtime version as well the nightly images used by the E2E tests. Signed-off-by: Sagar Muchhal <[email protected]>
fix image links from http to https
…ion-1.16 Updates the golang version to 1.16 & k8s version to 1.21
Signed-off-by: Yassine TIJANI <[email protected]>
- adds Secret as a credential option - adds VSphereIdentityRef - adds VSphereClusterIdentity as a credential option - utilizes AllowedNamespaces to restrict access to credentials - follows CAPI guidelines for multi-tenancy
…proposal First draft of multi-tenancy proposal
Add the failure domains API
Signed-off-by: Yassine TIJANI <[email protected]>
Signed-off-by: Yassine TIJANI <[email protected]>
add implementation details and API changes
enable multi-network PlacementConstrains
Signed-off-by: Yassine TIJANI <[email protected]>
Copy of PR1059 - move CPI over to CRS and refactor flavorgen
- VSphereCluster fetches secrete when verifying connectivity - VsphereVM utilizes identity when IdentityRef is specified in cluster - validates secret is stored in the correct namespace for the identity types - adds namespaces allowed logic - adds authentication related conditions to VSphereVM - adds vSphere secret to cluster templates - updates secrets with finalizers and ownerref when secret is meant to be used as the Identity - Adds VSphereClusterIdentity controller
…ip_in_vSphereVM add checks for network validation on update in vSphereMachine
Add multi-tenancy support
add command line args for keep alive feature go fmt change deafults update keepalivehandler use session from func keepalive default to false specify unit duration unit changes fix go-lint refactor params gofmt constant refactor to pkg/constant gofmt use ctrl logger code comment changes fix import order make rebase fix
sadysnaat
force-pushed
the
session-keepalive
branch
from
7fcf089 to
caf0d81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.