Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cert-manager api version #65

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

imdevin567
Copy link

clusterctl can't create the cert via cert-manager because the API version is wrong.

@spectro-prow spectro-prow requested a review from jzhoucliqr May 9, 2023 19:34
@spectro-prow
Copy link

Welcome @imdevin567! It looks like this is your first PR to spectrocloud/cluster-api-provider-maas 🎉

@spectro-prow
Copy link

Hi @imdevin567. Thanks for your PR.

I'm waiting for a spectrocloud member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sadysnaat sadysnaat changed the base branch from main-v1beta1-v2 to main May 15, 2023 14:21
@sadysnaat
Copy link
Contributor

@imdevin567 could you please help rebase the branch against main

@imdevin567
Copy link
Author

@sadysnaat the feature branch is up to date with main, is there anything else this is waiting on?

sadysnaat
sadysnaat previously approved these changes May 20, 2023
@spectro-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: imdevin567, sadysnaat
To complete the pull request process, please assign jzhoucliqr
You can assign the PR to them by writing /assign @jzhoucliqr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sadysnaat
Copy link
Contributor

@AmitSahastra let's verify cluster creation end to end with these changes

@AmitSahastra
Copy link
Collaborator

@imdevin567 Cloud you please squash commit or create a new pr with changes so we don't have old commits showing up here.

@AmitSahastra AmitSahastra self-requested a review October 5, 2023 07:17
Copy link
Collaborator

@AmitSahastra AmitSahastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squash commits or create new pr.

@imdevin567
Copy link
Author

Hey @AmitSahastra , sorry for the delay. I've resolved the branching/commit issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants