-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update cert-manager api version #65
base: main
Are you sure you want to change the base?
Conversation
Welcome @imdevin567! It looks like this is your first PR to spectrocloud/cluster-api-provider-maas 🎉 |
Hi @imdevin567. Thanks for your PR. I'm waiting for a spectrocloud member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@imdevin567 could you please help rebase the branch against main |
@sadysnaat the feature branch is up to date with main, is there anything else this is waiting on? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: imdevin567, sadysnaat The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@AmitSahastra let's verify cluster creation end to end with these changes |
@imdevin567 Cloud you please squash commit or create a new pr with changes so we don't have old commits showing up here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
squash commits or create new pr.
b6b4fd1
to
2b955e8
Compare
Hey @AmitSahastra , sorry for the delay. I've resolved the branching/commit issue. |
clusterctl
can't create the cert via cert-manager because the API version is wrong.