PCP-3237 #241
Open
PCP-3237 #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrade golang build version to 1.22 in Makefile
cherry-pick the change of PCP-2769
add toolchain go1.22.2 in go.mod
Pcp 2769 cherry pick
…heir controlplaneversion had a pre-release version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bugWhat this PR does / why we need it: PCP-3237 addresses palette downgrading node pools when GKE control plane is upgraded past the spc version. The changes in CAPG repository address a bug where if controlplaneversion in spec includes a patch or release version, it will trigger an upgrade; this causes the control plane to be perpetually stuck in upgrade to the same version. IE 1.28.11 being upgraded to 1.28.11.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # PCP-3237 (Also has a PR in palette repo)
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: