PE-5714 #321
Closed
PE-5714 #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brathina-spectro
requested changes
Dec 17, 2024
| @@ -529,18 +529,18 @@ harden_system() { | |||
| fi | |||
|
|
|||
| echo "Fix permission of all cron files" | |||
| for each in `echo /etc/cron.daily /etc/cron.hourly /etc/cron.d /etc/cron.monthly /etc/cron.weekly /etc/crontab` | |||
| for each in echo /etc/cron.daily /etc/cron.hourly /etc/cron.d /etc/cron.monthly /etc/cron.weekly /etc/crontab | |||
There was a problem hiding this comment.
This will not work as expected. the recommendation was to use the commands $(...) notation instead of legacy backticks
| fi | ||
| fi | ||
| done | ||
|
|
||
| echo "Remove cron and at deny files and have allow files in place" | ||
| echo "Remove cron and at deny files anf have allow files in place" |
There was a problem hiding this comment.
Could you fix the typo in this line ?
| echo "auth sufficient pam_faillock.so authsucc audit deny=4 fail_interval=900 unlock_time=600" | ||
| echo "auth requisite pam_deny.so" | ||
| echo "auth required pam_permit.so" | ||
| } > /etc/pam.d/common-auth |
There was a problem hiding this comment.
Using this approach, will the content get appended if the file has existing content?
There was a problem hiding this comment.
updated with >> /etc/pam.d/common-auth
| echo "Privileged containers are not allowed for the current user." | ||
| exit 1 | ||
| fi | ||
| if [ -z "$HTTP_PROXY" ] && [ -z "$HTTPS_PROXY" ] && [ -z "$(find certs -type f ! -name '.*' -print -quit)" ]; then | ||
| if [ -z "$HTTP_PROXY" ] && [ -z "$HTTPS_PROXY"]; then |
There was a problem hiding this comment.
The 3rd condition is missing ?
| @@ -94,14 +94,6 @@ PE_VERSION=$(git describe --abbrev=0 --tags) | |||
| SPECTRO_PUB_REPO=us-docker.pkg.dev/palette-images | |||
| EARTHLY_VERSION=v0.8.15 | |||
| source .arg | |||
|
|
|||
| # Workaround to support deprecated field PROXY_CERT_PATH | |||
There was a problem hiding this comment.
This special handling is missing in your changes. Could you check it out again ?
|
closing this PR, have a new one to work on the updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.