add ubuntu-advantage-tools to ubuntu-pro install flow #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advantage-tools need to be installed as per canonical documentation: https://ubuntu.com/server/docs/attach-your-ubuntu-pro-subscription
nianyush
approved these changes
May 23, 2024
|
looks good to me. do we want it in 4.4.0? @JPedro2 cc. @santhoshdaivajna @rishi-anand |
|
@nianyush ye we should have it in 4.4.0 if we are adding the |
|
This package is already installed by default on both Ubuntu 22.04 and 24.04, so why do we need this? |
|
The package is not installed in Ubuntu by default but we are adding it to the base image, I missed that. CanvOS/ubuntu-kairos-base/Dockerfile Line 91 in 05f4097 I'll close it :) |
|
Ahhh that explains why I never needed to install it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
advantage-tools needs to be installed as per ubuntu-pro's documentation: https://ubuntu.com/server/docs/attach-your-ubuntu-pro-subscription