Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include resource files for additional cultures in HelpProvider. #1717

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Tolitech
Copy link

As discussed in #1349 (@FrankRay78), I am adding 6 new resource files to enable the HelpProvider to display information in the following new cultures: it, ja, ko, pt, ru, zh-Hans.

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

I have only added 6 new resource files to the CLI project, without making any changes to the existing code. These additions simply ensure that the HelpProvider will display information in the configured culture.

The added cultures are:
Italian (it), Japanese (ja), Korean (ko), Portuguese (pt), Russian (ru), and Chinese (zh-Hans).


Please upvote 👍 this pull request if you are interested in it.

@Tolitech
Copy link
Author

@microsoft-github-policy-service agree

@patriksvensson
Copy link
Contributor

@FrankRay78 We would need to verify that the translations are correct.

@FrankRay78
Copy link
Contributor

FrankRay78 commented Dec 21, 2024

I was thinking we could put them through some translation websites/tools, just to make sure it didn't say 'I love dogs' or something like that.

Are you a native speaker of these six languages @Tolitech?

@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Dec 22, 2024
@Tolitech
Copy link
Author

Hello, @FrankRay78 ,
I completely understand your concern.

I am from Brazil, where we speak Portuguese, which is my native language.

The other languages were translated from English into their respective languages using artificial intelligence tools. I believe the results and adaptations are more reliable than those from traditional translation tools.

If we perform a reverse translation of these languages back into English, we can see that the translations are valid and accurate, and not intended as any sort of "joke."

That said, I understand and respect your concern—it is indeed a valid one.

If there is any way I can demonstrate to you that my intentions are genuine, please rest assured that I am more than willing to do so.

For reference, I was able to contribute to the MudBlazor project (translations to pt-BR) through the link below:
https://hosted.weblate.org/projects/mudblazor/

Despite the low adoption/use and confirmation by other users.

I believe the easiest way to prove the legitimacy of the information would be to open the .resx file, copy and paste the translated column, and ask, for example, an artificial intelligence tool to translate from culture "xx" to "en" (reverse translation).

This way, we would quickly see that there are no random texts provided.

Whatever you decide regarding this Pull Request will be fine with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ top pull request Top pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants