-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add missing docs & fix some errors in doc testing 📝 #124
doc: add missing docs & fix some errors in doc testing 📝 #124
Conversation
This should wrap up the difficulties I encountered while migrating.
I cannot detect a reason, can you confirm that this is also the case on your end and it's not my crazy Rust setup doing its thing again? @oscartbeaumont |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really love these changes!
I have made some changes and left some comments around them (nothing you need to fix). I would love some feedback on my changes before merging!
I also did some messing around and managed to get the doc test to build with tauri::generate_context
by copying exactly what Tauri do in their examples.
and turns out generic event's was never implemented but shown in the docs so also fixed that so the doc compiled.
closes #122
Changes
Builder
methods.