Skip to content

Merge pull request #51 from oscartbeaumont/dependabot/github_actions/… #70

Merge pull request #51 from oscartbeaumont/dependabot/github_actions/…

Merge pull request #51 from oscartbeaumont/dependabot/github_actions/… #70

Triggered via push September 11, 2023 03:34
Status Failure
Total duration 3m 12s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

ci.yml

on: push
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 10 warnings
build (macos-latest)
Process completed with exit code 101.
build (windows-latest)
The job was canceled because "macos-latest" failed.
build (windows-latest)
The operation was canceled.
build (ubuntu-latest)
The job was canceled because "macos-latest" failed.
build (ubuntu-latest)
The operation was canceled.
used `unwrap()` on a `Result` value: src/lib.rs#L357
warning: used `unwrap()` on a `Result` value --> src/lib.rs:357:50 | 357 | let (invoke_handler, event_collection) = self.export_inner().unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: if you don't want to handle the `Err` case gracefully, consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used note: the lint level is defined here --> src/lib.rs:91:22 | 91 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic | ^^^^^^^^^^^^^^^^^^^
the borrowed expression implements the required traits: src/event.rs#L211
warning: the borrowed expression implements the required traits --> src/event.rs:211:21 | 211 | window.once(&meta.wrap_with_plugin(Self::NAME), make_handler!(handler)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `meta.wrap_with_plugin(Self::NAME)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: src/event.rs#L201
warning: the borrowed expression implements the required traits --> src/event.rs:201:23 | 201 | window.listen(&meta.wrap_with_plugin(Self::NAME), make_handler!(handler)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `meta.wrap_with_plugin(Self::NAME)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: src/event.rs#L159
warning: the borrowed expression implements the required traits --> src/event.rs:159:28 | 159 | handle.once_global(&meta.wrap_with_plugin(Self::NAME), make_handler!(handler)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `meta.wrap_with_plugin(Self::NAME)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: src/event.rs#L149
warning: the borrowed expression implements the required traits --> src/event.rs:149:30 | 149 | handle.listen_global(&meta.wrap_with_plugin(Self::NAME), make_handler!(handler)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `meta.wrap_with_plugin(Self::NAME)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` implied by `#[warn(clippy::all)]`
`panic` should not be present in production code: src/event.rs#L81
warning: `panic` should not be present in production code --> src/event.rs:81:28 | 81 | .unwrap_or_else(|| panic!("Event {name} not found in registry!")) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic
the following explicit lifetimes could be elided: 'a: src/event.rs#L54
warning: the following explicit lifetimes could be elided: 'a --> src/event.rs:54:26 | 54 | pub fn get_or_manage<'a, R: Runtime>(handle: &'a impl Manager<R>) -> tauri::State<'a, Self> { | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes note: the lint level is defined here --> src/lib.rs:91:9 | 91 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic | ^^^^^^^^^^^ = note: `#[warn(clippy::needless_lifetimes)]` implied by `#[warn(clippy::all)]` help: elide the lifetimes | 54 - pub fn get_or_manage<'a, R: Runtime>(handle: &'a impl Manager<R>) -> tauri::State<'a, Self> { 54 + pub fn get_or_manage<R: Runtime>(handle: &impl Manager<R>) -> tauri::State<'_, Self> { |
`panic` should not be present in production code: src/event.rs#L34
warning: `panic` should not be present in production code --> src/event.rs:34:13 | 34 | panic!("Another event with name {} is already registered!", E::NAME) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic
`panic` should not be present in production code: src/event.rs#L30
warning: `panic` should not be present in production code --> src/event.rs:30:13 | 30 | panic!("Event {} registered twice!", E::NAME) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic note: the lint level is defined here --> src/lib.rs:91:43 | 91 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic | ^^^^^^^^^^^^^
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/