Rhino interfaces for testing #3523
Conversation
|
IProxyMapper moved to this usage while reusing source gen version that is host app specific |
adamhathcock
force-pushed
the
rhino-interfaces
branch
from
eaa0b1e
to
63d3016
Compare
DUI3-DX/Converters/Rhino/Speckle.Converters.Rhino7/ToSpeckle/Raw/BrepToSpeckleConverter.cs
Outdated
Show resolved
Hide resolved
DUI3-DX/Converters/Rhino/Speckle.Converters.Rhino7/ToSpeckle/Raw/BrepToSpeckleConverter.cs
Show resolved
Hide resolved
| @@ -27,7 +27,7 @@ public Base Convert(Type type, object obj) | |||
|
|
|||
| if (objectConverter == null) | |||
| { | |||
| throw new NotSupportedException($"No conversion found for {type.Name}"); | |||
| throw new NotSupportedException($"No conversion found for {type.Name} with actual type of {obj.GetType()}"); | |||
There was a problem hiding this comment.
Is it important to know the obj type here?
There was a problem hiding this comment.
This is for debugging purposes where the converter being asked for wasn't the type passed...this is a case for a lot of things at least in the Revit converter
There was a problem hiding this comment.
My only concern with this, is this is a very common user facing error message. And it would be nice for normal users to intuitively understand that "this type of object, isn't supported by us". I wasn't sure if this starts to confound some internal implementation complexity.
Perhaps we should instead by wrapping higher up...
Not a blocker, I just expect we'll have some feedback about this change to the error message.
DUI3-DX/Converters/Rhino/Speckle.Converters.Rhino7/ToSpeckle/Raw/PolylineToSpeckleConverter.cs
Show resolved
Hide resolved
https://spockle.atlassian.net/browse/DUI3-319