Interstate assignment to map #1790
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThrudPrimrose
changed the title
|
I should move this to a transformation. If the assigned symbol's value is used in more than one state, we need to wrap the whole subgraph where this value is necessary in a map and not just one state. |
ThrudPrimrose
requested review from
tbennun,
phschaad and
acalotoiu
and removed request for
tbennun,
phschaad and
acalotoiu
tbennun
requested changes
Dec 17, 2024
Comment on lines
+21
to
+25
| def _is_simple_assignment(expression_str): | ||
| expr = SymExpr(expression_str) | ||
| simplified_expr = expr.simplify() | ||
| is_constant = simplified_expr.is_number | ||
| return is_constant, simplified_expr |
There was a problem hiding this comment.
why not use symbolic.issymbolic()?
Comment on lines
+30
to
+31
| assignments = in_edge.data._assignments | ||
| condition = in_edge.data._cond_sympy |
There was a problem hiding this comment.
don't use the internal cached versions, use the methods that we provide.
|
|
||
| # Create cutout of the state as an SDFG (should have only one state) | ||
| # Create NestedSDFG, add it to the current state | ||
| cutout = SDFGCutout.singlestate_cutout(state, *state.nodes()) |
There was a problem hiding this comment.
We have utility functions called dace.sdfg.utils.nest_state_subgraph and nest_sdfg_subgraph that are much easier to use and more stable.
| @@ -0,0 +1,51 @@ | |||
| from typing import Dict | |||
| sdfg() | ||
|
|
||
| if __name__ == "__main__": | ||
| test_interstate_assignment() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maps simple interstate assignments to map encompassing the whole state.
Will complete after the bug fix on re-declaration of symbols is merge.
The pass only transforms if the assignment is a constant. (and the loops such as i = i + 1 should not be affected)