Fix adding Translatable to Panels #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freekmurze
requested changes
Nov 27, 2023
src/Translatable.php
Outdated
| $translatedField->panel = $this->panel; | ||
| $translatedField->assignedPanel = $this->assignedPanel; | ||
| $translatedField->attribute = 'translations_' . $originalAttribute . '_' . $locale; | ||
| $translatedField->panel ??= $this->panel; |
There was a problem hiding this comment.
I believe this operator is only available starting from PHP 7.4.
Could you also up the PHP requirements for this package?
There was a problem hiding this comment.
Sorry for the style changes I accidentally commited. I reverted them and also now use the ?? instead of ??=. I know this is a little less beautiful, but I don’t think it legitimates requiring [email protected]. What do you think?
Thanks for pointing out that this operator wasn’t available in 7.3.
This keeps PHP 7.3 support, since the null coalescing assigment operator was introduced in PHP 7.4.
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #87 by only assigning
panelandassignedPanelif these are not already filled.