Enable publishing any tag name with the install command #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misenhower
changed the title
freekmurze
requested changes
Aug 11, 2023
src/Commands/InstallCommand.php
Outdated
| @@ -117,32 +88,31 @@ public function handle() | |||
| } | |||
| } | |||
|
|
|||
| public function publishConfigFile(): self | |||
| public function publish(string $tag): self | |||
There was a problem hiding this comment.
Make this function variadic, so people can pass multiple tags.
$this->publish('config', 'assets');
|
Hey, sorry for the delay. I just pushed a change for that. Let me know what you think! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
->publish($tag)method on the install command that enables you to publish arbitrary tag names. For instance, we might use->publish('nova')to publish Nova resources from our package.This way, we don't need to add an individual method for each possible tag name. I've also replaced all the individual
$shouldPublish***properties with the new$publishesarray.Let me know what you think. Thanks!!