feat(collectBy): support dot-notation

spatie · Oct 16, 2023 · 41e7126 · 41e7126
1 parent 6f4e1fd
commit 41e7126
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/Macros/CollectBy.php b/src/Macros/CollectBy.php
@@ -2,6 +2,7 @@
 
 namespace Spatie\CollectionMacros\Macros;
 
+use Illuminate\Support\Arr;
 use Illuminate\Support\Collection;
 
 /**
@@ -19,7 +20,7 @@ class CollectBy
     public function __invoke()
     {
         return function ($key, $default = null): Collection {
-            return new static($this->get($key, $default));
+            return new static(Arr::get($this->items, $key, $default));
         };
     }
 }
diff --git a/tests/Macros/CollectByTest.php b/tests/Macros/CollectByTest.php
@@ -60,3 +60,22 @@
 
     expect($ingredients)->toEqual(new Collection());
 });
+
+it('collects path from collection using dot notation', function () {
+    $collection = new Collection([
+        'baz.qux' => 'quux',
+        'foo' => [
+            'bar' => [
+                'baz' => 100,
+            ],
+        ],
+    ]);
+
+    expect($collection->collectBy('foo.bar'))->toBeInstanceOf(Collection::class);
+    expect($collection->collectBy('foo.bar')->toArray())->toEqual([
+        'baz' => 100,
+    ]);
+
+    expect($collection->collectBy('baz.qux'))->toBeInstanceOf(Collection::class);
+    expect($collection->collectBy('baz.qux')->toArray())->toEqual(['quux']);
+});