Update how to fit and fill with a background color.

spatie · May 24, 2024 · c5a38f8 · c5a38f8
1 parent b3ddbf6
commit c5a38f8
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 5 deletions.
diff --git a/docs/image-manipulations/resizing-images.md b/docs/image-manipulations/resizing-images.md
@@ -70,8 +70,7 @@ Resizes the image to fit within the width and height boundaries without cropping
 # Example of how to set background colour to fill remaining pixels
 
 $image
-    ->fit(Fit::Fill, 497, 290)
-    ->background('#ff5733');
+    ->fit(fit: Fit::Fill, desiredWidth:  497,  desiredHeight: 290, backgroundColor: '#ff5733');
 ```
 
 ![Blue background on fit filled JPG](../../images/example-background.png)

diff --git a/tests/Manipulations/FitTest.php b/tests/Manipulations/FitTest.php
@@ -93,13 +93,11 @@
     $targetFile = $this->tempDir->path("{$driver->driverName()}/fit-background.png");
 
     $driver->loadFile(getTestJpg())
-        ->fit(Fit::Fill, 2000, 100)
-        //->background('ff5733')
+        ->fit(fit: Fit::Fill, desiredWidth:  800,  desiredHeight: 200, backgroundColor: '#0073ff')
         ->save($targetFile);
 
     assertMatchesImageSnapshot($targetFile);
 
-    //$this->fail('TODO: bug background color is not set');
 })->with('drivers');
 
 it('can do fit and crop', function (

diff --git a/...hots__/FitTest__it_can_fit_and_add_a_background_with_data_set_dataset_gd__1.png b/...hots__/FitTest__it_can_fit_and_add_a_background_with_data_set_dataset_gd__1.png
diff --git a/..._/FitTest__it_can_fit_and_add_a_background_with_data_set_dataset_imagick__1.png b/..._/FitTest__it_can_fit_and_add_a_background_with_data_set_dataset_imagick__1.png