Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure the matterjs bounce speed is consistent #114

Merged
merged 1 commit into from
May 21, 2022

Conversation

bryanbraun
Copy link
Collaborator

Fixes #113.

Testing instructions:

  1. Pull down this branch:
    • It's easy with gh: gh pr checkout 114
  2. Install dependencies: npm ci && npm run build
  3. Start the app: npm run start
  4. In firefox, browse to http://localhost:3000/#matter-js and confirm that the ball bounces at the same speed as the other demos. Note: it's ok if the ball loses bounce height over time... that's captured in a different issue.

Also modernizes the matterjs code a bit (by replacing var with const).

fixes sparkbox#113
@bryanbraun bryanbraun merged commit 68d3971 into sparkbox:main May 21, 2022
@bryanbraun bryanbraun deleted the fix--matterjs-bounce-speed branch May 21, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MatterJS Demo bounces too quickly in some browsers (Chrome / Firefox)
1 participant