Feat/anony #520
Merged
Feat/anony #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: anonymous chatting
Closed
2 tasks
✅ Deploy Preview for biseo-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
MinjaeKimmm
reviewed
Dec 2, 2024
| </BubbleItem> | ||
| )} | ||
| </div> | ||
| <div css={sendIconStyle}> |
There was a problem hiding this comment.
현재 button icon만 존재하고 onClick() 함수가 정의 되어있지 않습니다.
따라서 채팅에서 send 버튼 눌러도 보내지지 않고 Enter를 눌러야지만 보내집니다
packages/api/src/service/chat.ts
Outdated
| isAdmin: false, | ||
| displayName: "익명", | ||
| username: "익명", | ||
| }; |
There was a problem hiding this comment.
프론트에서 MessageType enum (interface/chat/common.ts)에서
export const MessageType = z.enum([
"message",
"notice",
"anonymous",
"adminnotice"
]);
이렇게 4가지 타입이 정의되어 있습니다
이번에 anonymous 추가하면서 4번째가 추가되었다고 보실 수 있습니다.
기존에 anonymous가 없을때 send하면 항상 "message" type으로 다시 돌려줄 수 있었는데 이제 anonymous 타입을 추가했으니 프론트엔드에서는
- 일반 메시지면 type: "message"
- 익명 메시지면 type: "anonymous"
를 기대하고 있습니다.
따라서 지금 현재 백엔드 코드 (sendQuery)에서는
type: "message" 즉 익명이든 아니든 무조건 type을 메시지로 돌려주고 있어서 프론트랑 백에서 싱크가 되지 않습니다.
type: type로 해서 dynamic하게 바꿔주는걸 추천합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약 *
#504 이슈 기반으로 아래 내역 작업 진행
스크린샷
이후 Task *