-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/minor UI updates #470
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,25 @@ | ||
import { css } from "@emotion/react"; | ||
import styled from "@emotion/styled"; | ||
import type { Color } from "@biseo/web/theme"; | ||
|
||
export const Divider = styled.hr<{ | ||
dir?: "horizontal" | "vertical"; | ||
color?: Color; | ||
}>( | ||
({ dir = "horizontal", theme }) => css` | ||
({ dir = "horizontal", color = "gray300", theme }) => css` | ||
border: none; | ||
${dir === "horizontal" | ||
? css` | ||
width: 100%; | ||
border-bottom: 1px solid ${theme.colors.gray300}; | ||
height: 1px; | ||
border: none; | ||
background-color: ${theme.colors[color]}; | ||
` | ||
: css` | ||
width: 1px; | ||
height: 100%; | ||
border-right: 1px solid ${theme.colors.gray300}; | ||
border: none; | ||
background-color: ${theme.colors[color]}; | ||
`} | ||
`, | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 anywhere인 이유가 있을까요?
Cell이 width가 작아서 줄 바꿈이 자주 일어나는 환경인지?
다른 line-break 스타일 (word 등)과 비교해서 어떤 점을 바탕으로 고르시게 되었나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line-break는 anywhere이 맞을 것 같네요 이슈 #446에 첨부해주신거 보니
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
table 칸에 들어가는 요소가 주로 띄어쓰기가 없이 작성되는 이름, 닉네임이라
anywhere
로 작성했습니다.참고로 이슈 #446 은 다른 분이 작업 중이라고 하셔서 (제욱이?) closed issue에 추가하지 않았습니다!