Improve monorepo builds #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biseo-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SnowSuno
commented
Jan 16, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "extends": ["@commitlint/config-conventional"], | |||
| "rules": { | |||
| "header-max-length": [2, "always", 50] | |||
| "header-max-length": [2, "always", 72] | |||
There was a problem hiding this comment.
그냥 이참에 commitlint 최대자 제한을 72자로 늘렸어요
72자가 recommended length더라고요
https://github.com/conventional-changelog/commitlint/blob/master/docs/reference-rules.md
SnowSuno
commented
Jan 16, 2024
| @@ -10,14 +10,15 @@ | |||
| "web": "pnpm -F @biseo/web", | |||
| "api": "dotenv -- pnpm -F @biseo/api", | |||
| "interface": "pnpm -F @biseo/interface", | |||
| "dev": "dotenv -- pnpm -r --stream dev", | |||
| "dev": "dotenv -- pnpm -r --stream --parallel dev", | |||
There was a problem hiding this comment.
@biseo/interface에 dev(build watch) script가 추가됨에 따라 이 명령이 끝나지 않으므로 --parallel 옵션을 주어 동시에 실행되도록 함
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약 *
기존의 모노레포 빌드 방식을 개선합니다.
tsconfig의module및target을NodeNext또는ESNext로 변경tsconfig.build.json삭제@biseo/interface의dev동작 방식을 build watch 방식으로 변경@/*) 가능해짐eslint의import/resolver관련 문제 해결이후 Task *
@biseo/web/*->@/*)