fix: diasbled button #435
Merged
fix: diasbled button #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biseo-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SnowSuno
reviewed
Nov 22, 2023
| <Text variant="boldtitle3" color="blue600"> | ||
| <Text | ||
| variant="boldtitle3" | ||
| color={validated ? "blue600" : "gray300"} |
There was a problem hiding this comment.
color css 속성은 inherit이 되니까 Button 컴포넌트에서 조정하는 것이 더 좋을 것 같아요!
그리고 atomic css 토큰을 적용하면 사실 아예 <Text /> 컴포넌트 자체가 필요 없어지긴 할것 같아요
SnowSuno
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약 *
fixes #241
너무 많은 게 바뀐 것 같아서... 새로 올립니당...
스크린샷
이후 Task *