Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agendaSection): scroll display none #431

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

minjoo0729
Copy link
Collaborator

요약 *

It closes #417

종료된 투표 클릭 시에 오른쪽에 알수없는 마진이 생기는 이슈 해결

알 수 없는 마진은 종료된 투표 section이 화면보다 길어지면 생기는 scroll이었음
scroll.ts에서 hidden이라는 새로운 친구를 추가해서 display: none으로 변경해서 해결

스크린샷

Biseo.-.Chrome.2023-11-01.20-26-13.mp4

이후 Task *

  • 없음

@minjoo0729 minjoo0729 self-assigned this Nov 1, 2023
Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for biseo-preview ready!

Name Link
🔨 Latest commit cd29f30
🔍 Latest deploy log https://app.netlify.com/sites/biseo-preview/deploys/65a91eec781a52000734f8c9
😎 Deploy Preview https://deploy-preview-431--biseo-preview.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@minjoo0729 minjoo0729 marked this pull request as ready for review November 1, 2023 11:37
JeukHwang
JeukHwang previously approved these changes Nov 1, 2023
Copy link
Contributor

@JeukHwang JeukHwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeukHwang
JeukHwang previously approved these changes Nov 8, 2023
Copy link
Contributor

@JeukHwang JeukHwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeukHwang JeukHwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm lint 하시고 에러 없는지 확인해주세요!

packages/web/src/components/organisms/AgendaSection.tsx Outdated Show resolved Hide resolved
@minjoo0729 minjoo0729 requested a review from JeukHwang November 22, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

종료된 투표 클릭시 마진 이상
2 participants