Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/UI bug #424

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Fix/UI bug #424

merged 3 commits into from
Nov 15, 2023

Conversation

hye1ee
Copy link
Contributor

@hye1ee hye1ee commented Oct 25, 2023

요약 *

  • 투표 참여 호버시 등장하는 정보 tag에 가독성을 위해 띄어쓰기 추가함
  • 투표 결과 바 색상이 figma 디자인과 다른 점 수정
  • 투표 결과 컴포넌트 borderColor 연하게 수정

It closes #414 #415 #416

스크린샷

스크린샷 2023-10-25 오후 10 57 16

이후

  • 없음

@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for biseo-preview ready!

Name Link
🔨 Latest commit 3e73b31
🔍 Latest deploy log https://app.netlify.com/sites/biseo-preview/deploys/65391fac19a93a0008764d54
😎 Deploy Preview https://deploy-preview-424--biseo-preview.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@JeukHwang JeukHwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 gap을 바꾸신 건 어떤 issue와 관련된 내용인가요?

@hye1ee
Copy link
Contributor Author

hye1ee commented Oct 26, 2023

혹시 gap을 바꾸신 건 어떤 issue와 관련된 내용인가요?

기존 figma디자인과 달라요!

Copy link
Collaborator

@minjoo0729 minjoo0729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@minjoo0729 minjoo0729 merged commit 9d939dd into main Nov 15, 2023
4 checks passed
@minjoo0729 minjoo0729 deleted the fix/ui-bug branch November 15, 2023 11:13
@Sanghou Sanghou mentioned this pull request Mar 20, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

투표바 색깔 변경 필요
3 participants