채팅 입력 글자수 제한 #363
Merged
채팅 입력 글자수 제한 #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biseo-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
withSang
changed the title
withSang
commented
Sep 13, 2023
| const validated = useMemo(() => input.value.trim().length > 0, [input.value]); | ||
|
|
||
| /** @constant 클라이언트와 서버에서 사용하는 채팅 메시지의 최대 길이를 지정합니다. */ | ||
| const maxMessageLength = 500; |
There was a problem hiding this comment.
서버, 클라이언트에서 모두 사용하는 값이라서 interface에 저장할 수 있으면 좋겠다고 생각했습니다!
withSang
commented
Sep 13, 2023
| const textAreaScrollStyle = css` | ||
| ${scroll.y} | ||
| ${scrollBar} | ||
| overflow-y: scroll; |
There was a problem hiding this comment.
overflow: scroll 대신 overflow: auto를 사용하면 스크롤바가 보일 때와 보이지 않을 때 텍스트 영역의 너비가 달라집니다.
withSang
commented
Sep 13, 2023
| @@ -7,7 +7,7 @@ import { Message } from "./common"; | |||
| * description | |||
| */ | |||
| export const Send = z.object({ | |||
| message: z.string().min(1), | |||
| message: z.string().min(1).max(500), | |||
There was a problem hiding this comment.
클라이언트가 채팅을 보내는 이벤트에서는 이 chat.Send 스키마에 따라 입력값 검증이 이루어집니다.
withSang
commented
Sep 13, 2023
| content: z.string().min(1), | ||
| resolution: z.string().min(1), | ||
| choices: z.array(z.string().min(1)).min(1), | ||
| title: z.string().min(1).max(255), |
There was a problem hiding this comment.
mysql에서 string 자료형의 길이는 [0, 255]입니다.
https://dev.mysql.com/doc/refman/8.0/en/string-type-syntax.html
babycroc
approved these changes
Sep 14, 2023
Comment on lines
+23
to
+27
| templateName: z.string().min(1).max(255), | ||
| title: z.string().min(1).max(255), | ||
| content: z.string().min(1).max(255), | ||
| resolution: z.string().min(1).max(255), | ||
| choices: z.array(z.string().min(1).max(255)), |
There was a problem hiding this comment.
옹 이제 템플릿이랑 유저태그 만드는 모달 쪽 프론트 로직에도 요거 검증이 들어가야겠네
관련 이슈 없으면 만들어줄 수 있나요??
minjoo0729
approved these changes
Sep 14, 2023
| content: z.string().min(1), | ||
| resolution: z.string().min(1), | ||
| choices: z.array(z.string().min(1)).min(1), | ||
| title: z.string().min(1).max(255), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It fixes #242, fixes #228
아래 이벤트들에 대해 string 길이 검증(min: 1, max: 255)을 적용했습니다. (backend min(1) validation이 잘 안됨 #242)
chat.sendadmin.agenda.createagenda.template.createuser.tag.create채팅 입력 창에 최대 글자 수(500자)와 최대 높이(30%)를 설정하고, 줄이 길어지는 경우 스크롤을 추가했습니다. ([채팅] 글이 아주 길어서 입력창이 채팅창을 가득 채우는 경우 스크롤 불가 & 채팅에 입력이 안됨 #228)
::-webkit-scrollbarcss 의사 요소은 크로미엄만 지원)Further issues