-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add react-select #305
Conversation
✅ Deploy Preview for biseo-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
a63265f
to
12a3480
Compare
태그 x 버튼 hitbox 가 너무 작은거 같기도 하네요.. 거의 정확히 눌러야 되는 수준이에요. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헿 내가 포기한 ui 구현하느라 수고했엉
justify="space-between" | ||
align="center" | ||
padHorizontal={10} | ||
bg={selected ? "blue100" : "white"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오잉 딴 건 다 selected가 gray100인데 얜 왜 블루지 좀 궁금한걸 @hye1ee
const onChangeSelectedTags = (selection: string[]) => { | ||
setSelectedTags(selection); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://sparcs.slack.com/archives/C01RC6QMSL8/p1694580896447669
요 슬랙 스레드에 관련 논의가 있는 것 같은데 여기도 useCallback을 적용할 수 있지 않을까? (잘 모름, 확신 없음)
움 그러게 전체적으로 아이콘들이 좀 작아보이긴 하당 |
아 맞다 까먹고 리뷰에 코멘트 못 썼는데 커서가 다 지금 디폴트 모양인 것 같던데 clickable component 위에 있으면 커서 모양 바뀌게도 해줘용 |
그리고 피그마 보니까 저것도 너무 많아지면 세로 스크롤 들어가는 디자인인 것 같은데 개수 많이 해서 테스트 해봤나요 안해봤으면 일단 high priority 이슈로 써두면 될듯 |
CSS Token 을 이용해서 그나마 깔끔하게 정리해봤습니다 |
5c69ec7
to
b2cce26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
우와아앙 해결하시느라 정말 고생하셨습니다!
@SnowSuno 먼가 중요한 건 다 고쳐진 것 같은데 import 형식 통일만 됐으몀 좋겠어요 그럼 일단 머지하고 자잘한 건 이슈로 남기면 될듯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
죠아요
아직 못 건드린 부분이 있다면 이슈로 남겨쥬세용
Resolves #304
github305.mp4