Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update MAST query for OPDs to also retrieve OPDs from FP6 #945

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented Dec 6, 2024

A little bit more for the field point switch, from testing this evening.

  • Update retrieve_mast_opd_table to retrieve from both FP1 + FP6 by default. This is necessary for it to find the OPDs from the new field point, for use in all the trending tools.
  • Update load_wss_opd_by_date debug/verbose message to include which field point was used. This is just a small cosmetic convenience.

@mperrin mperrin added bug Something isn't working enhancement New feature or request JWST Affects JWST models in WebbPSF labels Dec 6, 2024
@mperrin mperrin requested a review from obi-wan76 December 6, 2024 01:29
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.16%. Comparing base (94537f5) to head (7283bbb).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #945   +/-   ##
========================================
  Coverage    62.16%   62.16%           
========================================
  Files           15       15           
  Lines         7067     7067           
========================================
  Hits          4393     4393           
  Misses        2674     2674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@obi-wan76 obi-wan76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@obi-wan76 obi-wan76 merged commit 0929727 into spacetelescope:develop Dec 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request JWST Affects JWST models in WebbPSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants