Implemeted MRI IFU empirical cruciform [v2]

[mperrin]

Cloned from #928, and relocated into a PR branch owned by @mperrin. As noted in #928, the workflow for this one is atypical in that @patapisp started the branch and I @mperrin am now picking up to revise and finish it. By @patapisp:

This is the the start of a PR for finalising the broadening and cruciform implementation for the MIRI IFU mode. Added an additional option for model_type = "cruciform"

Remaining tasks:

• check normalisation convention when modifying PSF models
• changing the oversample parameter yields quite significant differences in the PSF models
• switch empirical broadening (now following Law+2023) to broadening due to sampling by detector and cube pixels

[pep8speaks]

Hello @mperrin, Thank you for updating !

• In the file webbpsf/detectors.py:

Line 584:126: E501 line too long (127 > 125 characters)

• In the file webbpsf/tests/test_miri.py:

Line 248:126: E501 line too long (129 > 125 characters)
Line 260:80: E202 whitespace before ')'
Line 260:126: E501 line too long (133 > 125 characters)
Line 262:1: W391 blank line at end of file

• In the file webbpsf/utils.py:

Line 1075:38: E231 missing whitespace after ','
Line 1087:28: E127 continuation line over-indented for visual indent
Line 1090:1: W391 blank line at end of file

Comment last updated at 2024-12-04 22:12:23 UTC

[codecov]

Codecov Report

Attention: Patch coverage is 57.83133% with 35 lines in your changes missing coverage. Please review.

Project coverage is 62.09%. Comparing base (3db3adf) to head (7c58d6f).
Report is 5 commits behind head on develop.

Files with missing lines	Patch %	Lines
webbpsf/match_data.py	7.14%	26 Missing ⚠️
webbpsf/utils.py	16.66%	5 Missing ⚠️
webbpsf/detectors.py	91.11%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #930      +/-   ##
===========================================
- Coverage    62.26%   62.09%   -0.18%     
===========================================
  Files           15       15              
  Lines         7038     7104      +66     
===========================================
+ Hits          4382     4411      +29     
- Misses        2656     2693      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mperrin]

Future development and implementation of this PR will be at spacetelescope/stpsf#53