Update NIRSpec aperture PAs #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could go into either 1.3.1 or be saved for later. @obi-wan76 your choice, just let me know, or tag the Milestone on this PR, please. |
obi-wan76
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #868 by updating the NIRSpec aperture PAs from PySIAF, including the very slightly different aperture PAs for NRS1 vs NRS2 and for different apertures such as the IFU or slit apertures. Tiny effect, fraction of a degree, so will have only a small effect on PSFs at most. But it's easy to do so we might as well. (Much simpler than the corresponding code for MIRI which I already wrote in #770).