Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set version number explicitly #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Johannes-Sahlmann
Copy link
Collaborator

Minor code developments.

@Johannes-Sahlmann
Copy link
Collaborator Author

@jameswu2 could you please have a look at this PR?

The problem is a stricter checking of versioning in pip (popping up in several places, see e.g. spacetelescope/pystortion#10).

Ideally, one would have to fix the underlying problem, of consistently setting the version number (automatically, when possible).

@jameswu2
Copy link
Collaborator

@Johannes-Sahlmann Hi Johannes, my involvement with this project is limited to my role as admin for the GitHub org. Is there anyone else you can request a review from?

@Johannes-Sahlmann
Copy link
Collaborator Author

@tonysohn I hope you are doing well.

Would you have time to have a look at this PR? This package is a dependency of https://github.com/spacetelescope/astrometry-scripts and I hope this issue does not cause problems there, but I did not check.

@tonysohn
Copy link

@Johannes-Sahlmann Hi Johannes. I'm doing well here, and hope you are, too. I do have a fixed version myself (https://github.com/tonysohn/uhelpers). But broadly, I actually started an entirely new package based on your scripts. I wanted to have most of the relevant scripts in a single repo with less dependencies. The new script lies at: https://www.github.com/tonysohn/jwst_fpa . Not sure what to do with these scripts you have here...

@Johannes-Sahlmann
Copy link
Collaborator Author

Thanks @tonysohn . What does your fix consist in and why don't you open a pull request to get it into the upstream repo?

Also related, I ran into similar problems with my pystrometry package, which I fixed today (https://github.com/Johannes-Sahlmann/pystrometry).

The problem was that I usually did not do proper releases of my packages (with dev in the version name) and doing that fixes the problems related to the newly-raised pip errors, as far as I can see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants