-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set version number explicitly #3
base: master
Are you sure you want to change the base?
Conversation
@jameswu2 could you please have a look at this PR? The problem is a stricter checking of versioning in pip (popping up in several places, see e.g. spacetelescope/pystortion#10). Ideally, one would have to fix the underlying problem, of consistently setting the version number (automatically, when possible). |
@Johannes-Sahlmann Hi Johannes, my involvement with this project is limited to my role as admin for the GitHub org. Is there anyone else you can request a review from? |
@tonysohn I hope you are doing well. Would you have time to have a look at this PR? This package is a dependency of https://github.com/spacetelescope/astrometry-scripts and I hope this issue does not cause problems there, but I did not check. |
@Johannes-Sahlmann Hi Johannes. I'm doing well here, and hope you are, too. I do have a fixed version myself (https://github.com/tonysohn/uhelpers). But broadly, I actually started an entirely new package based on your scripts. I wanted to have most of the relevant scripts in a single repo with less dependencies. The new script lies at: https://www.github.com/tonysohn/jwst_fpa . Not sure what to do with these scripts you have here... |
Thanks @tonysohn . What does your fix consist in and why don't you open a pull request to get it into the upstream repo? Also related, I ran into similar problems with my pystrometry package, which I fixed today (https://github.com/Johannes-Sahlmann/pystrometry). The problem was that I usually did not do proper releases of my packages (with |
Minor code developments.