-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add _model_to_exptype method to AbstractModelLibrary #201
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
==========================================
- Coverage 94.62% 94.62% -0.01%
==========================================
Files 37 37
Lines 3126 3125 -1
==========================================
- Hits 2958 2957 -1
Misses 168 168 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we also need to change the way exptype
is set on this line? Other than that this looks good pending passing regtests
Thanks for taking a look. That method is overridden in the jwst subclass and updated in spacetelescope/jwst#8918 |
Missed that, thanks, looks good |
This PR adds a method
_model_to_exptype
toAbstractModelLibrary
to allow jwst to control howexptype
is determined whenModelLibrary
is created from a list of models.With spacetelescope/jwst#8918 this will address JP-3787.
jwst regtests: https://github.com/spacetelescope/RegressionTests/actions/runs/11487054306
Romancal regtests: https://github.com/spacetelescope/RegressionTests/actions/runs/11487038188
show 1 unrelated failure matching main: https://github.com/spacetelescope/RegressionTests/actions/runs/11470564200/job/31920046203
Fixes #200
Tasks
docs/
pageno-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)"git+https://github.com/<fork>/stpipe@<branch>"
)jwst
regression testromancal
regression testnews fragment change types...
changes/<PR#>.feature.rst
: new featurechanges/<PR#>.bugfix.rst
: fixes an issuechanges/<PR#>.doc.rst
: documentation changechanges/<PR#>.removal.rst
: deprecation or removal of public APIchanges/<PR#>.misc.rst
: infrastructure or miscellaneous change