Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support python 3.13 #193

Merged
merged 2 commits into from
Oct 14, 2024
Merged

support python 3.13 #193

merged 2 commits into from
Oct 14, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Oct 8, 2024

Update CI to test with python 3.13.

jwst downstream failure is unrelated see #191

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stpipe@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.26%. Comparing base (3a03c8c) to head (c55d0d2).
Report is 29 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (3a03c8c) and HEAD (c55d0d2). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (3a03c8c) HEAD (c55d0d2)
4 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #193       +/-   ##
===========================================
- Coverage   94.66%   75.26%   -19.40%     
===========================================
  Files          37       34        -3     
  Lines        3109     2689      -420     
===========================================
- Hits         2943     2024      -919     
- Misses        166      665      +499     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review October 8, 2024 18:29
@braingram braingram requested a review from a team as a code owner October 8, 2024 18:29
@braingram braingram requested a review from jhunkeler October 8, 2024 18:30
Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor edit to the change log

changes/193.feature.rst Outdated Show resolved Hide resolved
@braingram braingram enabled auto-merge October 14, 2024 13:31
@braingram braingram merged commit 4667ada into spacetelescope:main Oct 14, 2024
15 of 16 checks passed
@braingram braingram deleted the py313 branch October 14, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants