Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Use ModelContainer.get_crds_parameters #144

Closed

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Feb 26, 2024

Requires: spacetelescope/jwst#8310
as ModelContainer.get_crds_parameters (unused prior to this PR) fails for ModelContainer instances not read from an association.

@braingram braingram changed the title Use get crds parameters TEST: Use ModelContainer.get_crds_parameters Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 59.33%. Comparing base (aea1617) to head (b4d29ee).
Report is 1 commits behind head on main.

Files Patch % Lines
src/stpipe/step.py 0.00% 3 Missing ⚠️
src/stpipe/pipeline.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   59.15%   59.33%   +0.18%     
==========================================
  Files          24       24              
  Lines        1611     1606       -5     
==========================================
  Hits          953      953              
+ Misses        658      653       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant