Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop bundling configobj #122

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented Oct 24, 2023

Currently stpipe bundles its own copy of configobj; however, astropy also bundles a copy of configobj. The only major differences between the stpipe version and the astropy version are the changes from #108 (this was recently fixed by astropy) and some errant conversions of strings to f-strings via applications of automated tools. Since astropy is a required dependency of stpipe, we might as well just use the configobj maintained and bundled directly by astropy rather than further duplicating it.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 68 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/stpipe/cli/command.py 100.00% <ø> (+27.27%) ⬆️
src/stpipe/cli/list.py 97.29% <100.00%> (ø)
src/stpipe/cli/main.py 87.17% <100.00%> (ø)
src/stpipe/datamodel.py 100.00% <100.00%> (+11.11%) ⬆️
src/stpipe/exceptions.py 62.50% <100.00%> (-4.17%) ⬇️
src/stpipe/format_template.py 97.61% <100.00%> (-0.06%) ⬇️
src/stpipe/entry_points.py 50.00% <0.00%> (+2.63%) ⬆️
src/stpipe/utilities.py 76.59% <75.00%> (-0.49%) ⬇️
src/stpipe/config.py 58.53% <0.00%> (ø)
src/stpipe/crds_client.py 35.13% <0.00%> (+1.80%) ⬆️
... and 8 more

📢 Thoughts on this report? Let us know!

@WilliamJamieson
Copy link
Collaborator Author

@WilliamJamieson WilliamJamieson marked this pull request as ready for review October 25, 2023 15:50
@WilliamJamieson WilliamJamieson requested a review from a team as a code owner October 25, 2023 15:50
@WilliamJamieson WilliamJamieson force-pushed the refactor/remove_extern branch 3 times, most recently from 447337d to 62d93e4 Compare October 31, 2023 16:36
Copy link
Collaborator

@perrygreenfield perrygreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and well worth doing.

@WilliamJamieson WilliamJamieson merged commit 99a828f into spacetelescope:master Nov 7, 2023
12 of 13 checks passed
@WilliamJamieson WilliamJamieson deleted the refactor/remove_extern branch November 7, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants