-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop bundling configobj
#122
Merged
WilliamJamieson
merged 3 commits into
spacetelescope:master
from
WilliamJamieson:refactor/remove_extern
Nov 7, 2023
Merged
Stop bundling configobj
#122
WilliamJamieson
merged 3 commits into
spacetelescope:master
from
WilliamJamieson:refactor/remove_extern
Nov 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
📢 Thoughts on this report? Let us know! |
WilliamJamieson
force-pushed
the
refactor/remove_extern
branch
from
October 24, 2023 19:40
035a3db
to
a0c7604
Compare
This passes the regression tests: |
WilliamJamieson
force-pushed
the
refactor/remove_extern
branch
3 times, most recently
from
October 31, 2023 16:36
447337d
to
62d93e4
Compare
WilliamJamieson
requested review from
perrygreenfield,
nden and
zacharyburnett
November 7, 2023 14:38
WilliamJamieson
force-pushed
the
refactor/remove_extern
branch
from
November 7, 2023 14:55
62d93e4
to
b16dbbb
Compare
zacharyburnett
approved these changes
Nov 7, 2023
perrygreenfield
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and well worth doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
stpipe
bundles its own copy ofconfigobj
; however,astropy
also bundles a copy ofconfigobj
. The only major differences between thestpipe
version and theastropy
version arethe changes from #108(this was recently fixed by astropy) and some errant conversions of strings tof-strings
via applications of automated tools. Sinceastropy
is a required dependency ofstpipe
, we might as well just use theconfigobj
maintained and bundled directly byastropy
rather than further duplicating it.