Switch abstract interfaces to protocols #120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
===========================================
+ Coverage 80.80% 95.02% +14.22%
===========================================
Files 37 39 +2
Lines 2849 3195 +346
===========================================
+ Hits 2302 3036 +734
+ Misses 547 159 -388 ☔ View full report in Codecov by Sentry. |
|
Passes regression tests: |
WilliamJamieson
force-pushed
the
refactor/protocols
branch
3 times, most recently
from
b4c6fcd to
93bd7eb
Compare
WilliamJamieson
force-pushed
the
refactor/protocols
branch
2 times, most recently
from
2c1b09e to
b85a10e
Compare
WilliamJamieson
force-pushed
the
refactor/protocols
branch
from
46e71f3 to
1349871
Compare
WilliamJamieson
force-pushed
the
refactor/protocols
branch
from
1349871 to
5cfeef2
Compare
WilliamJamieson
force-pushed
the
refactor/protocols
branch
from
5cfeef2 to
633dcea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
AbstractDataModelobject with a python protocol as described in #118 (comment). This is a bit cleaner than the current implementation.This PR also implements aModelContainerprotocol which provides the same functionality of #118.Note that the only functional change is that
issubclasswill does not function quite correctly due to the missing__hash__see python/mypy#3939 for a more detailed discussion of this. Since in general the idea of theAbstractDataModelwas to provide a way to check if some non-inheriting object instance followed the structure it described,issubclasschecks are unnecessary and likely only limited tostpipeitself, which itself makes no such checks.