-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use PyPI upload workflow from OpenAstronomy #111
use PyPI upload workflow from OpenAstronomy #111
Conversation
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With my suggestions below,
stpipe/.github/workflows/ci.yml
Line 26 in 510e4a2
- linux: build-dist |
dd9b315
to
d3ee087
Compare
I wonder why the publish workflow has not been triggered... Would a close/reopen work to trigger that? |
found it, it was just a syntax error |
0af6d2e
to
2b9d3d5
Compare
unfortunately, it looks like GitHub categorizes the actions on the Actions tab by filename, so we can't rename the actual workflow files without creating a new duplicate category with the same name. If people see |
Co-authored-by: William Jamieson <[email protected]>
cfa0b58
to
3531c67
Compare
This PR changes the PyPI upload process to use the OpenAstronomy workflow instead of the STScI one. The workflow in this PR is configured to test the build with each pull request push, and then publish upon an official release.
Additionally, we can't use this workflow until we make a PyPI token (with write / upload permission to packages) for the STScI maintainer account. Currently, we use a username and password to PyPI; however, this method will be deprecated at some point in the future in favor of tokens.