Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use PyPI upload workflow from OpenAstronomy #111

Merged
merged 15 commits into from
Oct 2, 2023

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Sep 19, 2023

This PR changes the PyPI upload process to use the OpenAstronomy workflow instead of the STScI one. The workflow in this PR is configured to test the build with each pull request push, and then publish upon an official release.

Additionally, we can't use this workflow until we make a PyPI token (with write / upload permission to packages) for the STScI maintainer account. Currently, we use a username and password to PyPI; however, this method will be deprecated at some point in the future in favor of tokens.

@zacharyburnett zacharyburnett added the no-changelog-entry-needed does not require an entry in `CHANGES.rst` label Sep 19, 2023
@zacharyburnett zacharyburnett self-assigned this Sep 19, 2023
@zacharyburnett zacharyburnett marked this pull request as ready for review September 19, 2023 17:22
@zacharyburnett zacharyburnett requested a review from a team as a code owner September 19, 2023 17:22
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@zacharyburnett zacharyburnett marked this pull request as draft September 19, 2023 17:31
Copy link
Collaborator

@WilliamJamieson WilliamJamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With my suggestions below,

- linux: build-dist
can be removed as the workflow should be triggered by pull_requests, but not be uploaded to PyPi.

.github/workflows/publish-to-pypi.yml Outdated Show resolved Hide resolved
.github/workflows/publish-to-pypi.yml Outdated Show resolved Hide resolved
@WilliamJamieson
Copy link
Collaborator

I wonder why the publish workflow has not been triggered... Would a close/reopen work to trigger that?

@zacharyburnett
Copy link
Collaborator Author

I wonder why the publish workflow has not been triggered... Would a close/reopen work to trigger that?

found it, it was just a syntax error

@zacharyburnett zacharyburnett force-pushed the ci/openastronomy branch 3 times, most recently from 0af6d2e to 2b9d3d5 Compare September 19, 2023 18:06
@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Sep 19, 2023

unfortunately, it looks like GitHub categorizes the actions on the Actions tab by filename, so we can't rename the actual workflow files without creating a new duplicate category with the same name. If people see Publish to PyPI running on their pull request, they might panic and think it's actually publishing; thus I renamed the job to build, but am unable to rename publish-to-pypi.yml

.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test_on_schedule.yml Outdated Show resolved Hide resolved
@zacharyburnett zacharyburnett marked this pull request as ready for review September 20, 2023 13:37
@zacharyburnett zacharyburnett merged commit 7d3d12c into spacetelescope:master Oct 2, 2023
10 of 11 checks passed
@zacharyburnett zacharyburnett deleted the ci/openastronomy branch October 2, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed does not require an entry in `CHANGES.rst`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants