Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Use hash for Action workflow versions and update if needed #168

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Sep 27, 2024

As recommended by https://scientific-python.org/specs/spec-0008/#pin-github-actions-release-workflows-to-their-full-release-commit-shas , this PR changes your Actions workflow version pins to hashes, and updates to latest release hashes (at the time of writing) if needed.

This is an automated update made by the batchpr tool 🤖 - feel free to close if it doesn't look good! You can report issues to @pllim.

👻

@pllim pllim requested a review from a team as a code owner September 27, 2024 17:00
@github-actions github-actions bot added the testing changes to automation and testing label Sep 27, 2024
@zacharyburnett
Copy link
Collaborator

GitHub actions must be pinned using full commit SHA corresponding to the release version being used. Using versions or small hashes is susceptible to attacks.

Oh interesting, I guess someone upstream could potentially re-tag an action with malicious code

@zacharyburnett zacharyburnett merged commit 2f0c3e4 into spacetelescope:main Sep 30, 2024
18 of 19 checks passed
@pllim pllim deleted the action-ver-hash branch September 30, 2024 14:23
@pllim
Copy link
Contributor Author

pllim commented Sep 30, 2024

Yes it is a possibility especially with random third-party actions with unknown authors.

@pllim
Copy link
Contributor Author

pllim commented Sep 30, 2024

Even with known packages, only takes one malicious actor for it to happen, if you remember recent news.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing changes to automation and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants