Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for python 3.10 #327

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

WilliamJamieson
Copy link
Collaborator

Per spec 0 we should be dropping python 3.10 support. This PR drops 3.10 support and then bumps all the testing envs by one python version. It is based off of #300 so that python 3.13 can be used in the tests.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stcal@<branch>")
news fragment change types...
  • changes/<PR#>.apichange.rst: change to public API
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner December 18, 2024 18:52
@WilliamJamieson WilliamJamieson requested review from zacharyburnett and removed request for a team December 18, 2024 18:52
@WilliamJamieson WilliamJamieson mentioned this pull request Dec 18, 2024
7 tasks
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.55%. Comparing base (728b877) to head (09fedbf).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
- Coverage   29.56%   29.55%   -0.01%     
==========================================
  Files          37       36       -1     
  Lines        8332     7949     -383     
==========================================
- Hits         2463     2349     -114     
+ Misses       5869     5600     -269     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamJamieson WilliamJamieson force-pushed the drop_py313 branch 2 times, most recently from 5d65fb3 to 64bc0e9 Compare December 18, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants