Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull common parts of skymatch from romancal and jwst into stcal #310

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Move to using gwcs for region

6202d38
Select commit
Loading
Failed to load commit list.
Open

Pull common parts of skymatch from romancal and jwst into stcal #310

Move to using gwcs for region
6202d38
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 3, 2025 in 1s

85.05% (+55.47%) compared to 35726e9

View this Pull Request on Codecov

85.05% (+55.47%) compared to 35726e9

Details

Codecov Report

Attention: Patch coverage is 69.57774% with 317 lines in your changes missing coverage. Please review.

Project coverage is 85.05%. Comparing base (35726e9) to head (6202d38).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/stcal/skymatch/skyimage.py 61.09% 270 Missing ⚠️
src/stcal/skymatch/skymatch.py 83.90% 47 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #310       +/-   ##
===========================================
+ Coverage   29.57%   85.05%   +55.47%     
===========================================
  Files          36       53       +17     
  Lines        7949    10028     +2079     
===========================================
+ Hits         2351     8529     +6178     
+ Misses       5598     1499     -4099     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.