Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redundant calculations, unneeded array allocations from jump step #302

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Merge branch 'spacetelescope:main' into jumpdetection_speedup

412f078
Select commit
Loading
Failed to load commit list.
Draft

Removed redundant calculations, unneeded array allocations from jump step #302

Merge branch 'spacetelescope:main' into jumpdetection_speedup
412f078
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 23, 2024 in 0s

86.89% (+57.31%) compared to 35726e9

View this Pull Request on Codecov

86.89% (+57.31%) compared to 35726e9

Details

Codecov Report

Attention: Patch coverage is 85.71429% with 10 lines in your changes missing coverage. Please review.

Project coverage is 86.89%. Comparing base (35726e9) to head (412f078).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/stcal/jump/twopoint_difference.py 85.71% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #302       +/-   ##
===========================================
+ Coverage   29.57%   86.89%   +57.31%     
===========================================
  Files          36       49       +13     
  Lines        7949     8949     +1000     
===========================================
+ Hits         2351     7776     +5425     
+ Misses       5598     1173     -4425     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.