Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch docs theme to sphinx_rtd, unpin sphinx #272

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jul 19, 2024

This PR switches the sphinx theme to sphinx_rtd_theme (as was done for jwst, stpipe, romancal, etc).

This also fixes the broken search.

If this conflicts with:
#267
or
#270

I suggest we wait until after those are merged.

Link to built docs: https://stcal--272.org.readthedocs.build/en/272/index.html

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@github-actions github-actions bot added documentation Improvements or additions to documentation installation labels Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (cd47dc6) to head (bd72ed5).
Report is 177 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   84.38%   84.38%           
=======================================
  Files          41       41           
  Lines        7557     7557           
=======================================
  Hits         6377     6377           
  Misses       1180     1180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review July 19, 2024 17:47
@braingram braingram requested a review from a team as a code owner July 19, 2024 17:47
@braingram braingram requested review from nden and zacharyburnett July 26, 2024 13:28
@braingram braingram merged commit 61ff80a into spacetelescope:main Aug 29, 2024
24 of 26 checks passed
@braingram braingram deleted the docs_theme branch August 29, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation installation no-changelog-entry-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants