Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3521: Fix jump multiprocessing error #239

Merged
merged 19 commits into from
Feb 1, 2024

Conversation

mwregan2
Copy link
Collaborator

@mwregan2 mwregan2 commented Jan 25, 2024

Resolves JP-3521

Closes spacetelescope/jwst#8221

This PR addresses the different results return from the Jump step when switching from single core processing to multiprocessing. The main problem was caused by calculating the number of rows per slice using floating point division. This lead to some rows not getting processed.
In addition, the 4 neighbor flagging in multiprocessing was adding the jump bit to pixels that were already flagged as do_not_use or saturated.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@mwregan2 mwregan2 requested a review from a team as a code owner January 25, 2024 19:14
@github-actions github-actions bot added the jump label Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (30c41af) 84.31% compared to head (a061bdd) 85.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   84.31%   85.94%   +1.62%     
==========================================
  Files          35       35              
  Lines        6452     6523      +71     
==========================================
+ Hits         5440     5606     +166     
+ Misses       1012      917      -95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/stcal/jump/jump.py Outdated Show resolved Hide resolved
src/stcal/jump/jump.py Outdated Show resolved Hide resolved
@hbushouse hbushouse changed the title Jump multiprocessing error JP-3521: Fix jump multiprocessing error Jan 25, 2024
CHANGES.rst Outdated Show resolved Hide resolved
src/stcal/jump/jump.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to work now.

@hbushouse hbushouse merged commit dfa9a50 into spacetelescope:main Feb 1, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data differences running with multiprocessing
3 participants