-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Resolve some skips #186
Open
WilliamJamieson
wants to merge
1
commit into
spacetelescope:main
Choose a base branch
from
WilliamJamieson:testing/fix_skips
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
MNT: Resolve some skips #186
WilliamJamieson
wants to merge
1
commit into
spacetelescope:main
from
WilliamJamieson:testing/fix_skips
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamJamieson
commented
Aug 9, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
=======================================
Coverage 85.98% 85.98%
=======================================
Files 35 35
Lines 6542 6542
=======================================
Hits 5625 5625
Misses 917 917 ☔ View full report in Codecov by Sentry. |
WilliamJamieson
commented
Aug 9, 2023
kmacdonald-stsci
approved these changes
Aug 9, 2023
WilliamJamieson
force-pushed
the
testing/fix_skips
branch
2 times, most recently
from
August 11, 2023 15:41
f931384
to
239ddb9
Compare
WilliamJamieson
force-pushed
the
testing/fix_skips
branch
from
October 11, 2023 18:42
239ddb9
to
ca02e8e
Compare
WilliamJamieson
force-pushed
the
testing/fix_skips
branch
from
October 27, 2023 17:29
ca02e8e
to
d7c5137
Compare
WilliamJamieson
force-pushed
the
testing/fix_skips
branch
4 times, most recently
from
November 11, 2023 02:13
9cf645b
to
c6743b3
Compare
WilliamJamieson
force-pushed
the
testing/fix_skips
branch
3 times, most recently
from
November 21, 2023 14:50
f2e3579
to
82cdee3
Compare
WilliamJamieson
force-pushed
the
testing/fix_skips
branch
from
February 13, 2024 17:26
82cdee3
to
52bfe53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some of the skips which were added to tests.
Checklist
CHANGES.rst
(either inBug Fixes
orChanges to API
)