Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps/numpy-2-compat #92

Merged

Conversation

alphasentaurii
Copy link
Collaborator

@alphasentaurii alphasentaurii commented Sep 17, 2024

  • Adds optional arg encoding=bytes in preprocessor.transform.hypersonic_pliers which uses np.loadtxt. This ensures consistent behavior for future upgrades to Numpy>=2.0 where the default will be changed to str.
  • Minor formatting fixes: use isinstance() for type checking

@alphasentaurii alphasentaurii merged commit a36bffe into spacetelescope:develop Sep 17, 2024
8 checks passed
@alphasentaurii alphasentaurii deleted the numpy-2-compatibility branch September 17, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant