Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement outlier detection step. #979

Closed
wants to merge 3 commits into from
Closed

Implement outlier detection step. #979

wants to merge 3 commits into from

Conversation

mairanteodoro
Copy link
Collaborator

@mairanteodoro mairanteodoro commented Nov 7, 2023 •
edited
Loading

Resolves RCAL-501

This PR addresses the implementation of the outlier detection step for Roman.

The link to the regression test results is here.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Nov 7, 2023
@mairanteodoro mairanteodoro force-pushed the RCAL-501-outlier-detection branch from 117c148 to 76c6cf4 Compare November 7, 2023 20:21
@mairanteodoro mairanteodoro marked this pull request as ready for review November 7, 2023 20:22
@mairanteodoro mairanteodoro requested a review from a team as a code owner November 7, 2023 20:22
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 306 lines in your changes are missing coverage. Please review.

Files Coverage Δ
romancal/lib/dqflags.py 100.00% <ø> (ø)
romancal/resample/resample.py 72.47% <37.50%> (-5.54%) ⬇️
romancal/datamodels/container.py 75.75% <9.52%> (-12.54%) ⬇️
...mancal/outlier_detection/outlier_detection_step.py 21.78% <19.38%> (-13.94%) ⬇️
romancal/outlier_detection/outlier_detection.py 15.96% <15.96%> (ø)

📢 Thoughts on this report? Let us know!

@mairanteodoro
Copy link
Collaborator Author

I found an issue with my rebasing; will fix it.

@mairanteodoro mairanteodoro mentioned this pull request Nov 8, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nden nden Awaiting requested review from nden

@schlafly schlafly Awaiting requested review from schlafly

@ddavis-stsci ddavis-stsci Awaiting requested review from ddavis-stsci

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mairanteodoro