Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't run tests on romancal/scripts #975

Merged
merged 1 commit into from
Nov 6, 2023
Merged

don't run tests on romancal/scripts #975

merged 1 commit into from
Nov 6, 2023

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Nov 6, 2023 •
edited
Loading

This PR addresses the issue where test collection fails upon attempting to import in the new static_preview script:
https://github.com/spacetelescope/stcal/actions/runs/6772518526/job/18405280890#step:10:174

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@zacharyburnett zacharyburnett self-assigned this Nov 6, 2023
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Nov 6, 2023
@zacharyburnett zacharyburnett changed the title don't test script directory don't run tests on romancal/scripts Nov 6, 2023
@zacharyburnett zacharyburnett marked this pull request as ready for review November 6, 2023 19:13
@zacharyburnett zacharyburnett requested a review from a team as a code owner November 6, 2023 19:13
schlafly
schlafly approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@zacharyburnett zacharyburnett merged commit 3fbf571 into spacetelescope:main Nov 6, 2023
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlafly schlafly schlafly approved these changes

Assignees

@zacharyburnett zacharyburnett

Labels
dependencies Pull requests that update a dependency file no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacharyburnett @schlafly