Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed asn_from_list script #972

Merged
merged 2 commits into from
Nov 6, 2023
Merged

fixed asn_from_list script #972

merged 2 commits into from
Nov 6, 2023

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Nov 6, 2023 •
edited
Loading

This PR fixes the asn_from_list

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Nov 6, 2023
@zacharyburnett zacharyburnett changed the title call function directly from project.scripts fixed asn_from_list script Nov 6, 2023
@zacharyburnett zacharyburnett marked this pull request as ready for review November 6, 2023 13:51
@zacharyburnett zacharyburnett requested a review from a team as a code owner November 6, 2023 13:51
schlafly
schlafly approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zacharyburnett zacharyburnett merged commit 552c694 into spacetelescope:main Nov 6, 2023
23 checks passed
@zacharyburnett zacharyburnett deleted the script/consolidate branch November 6, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlafly schlafly schlafly approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacharyburnett @schlafly