Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove usage of ddtrace as DataDog stopped working #967

Closed

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Nov 1, 2023

DataDog stopped accepting ddtrace output (see https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2Fromancal/detail/romancal/1103/pipeline/) so this PR removes usage of ddtrace in testing so the builds can continue

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Nov 1, 2023

@zacharyburnett zacharyburnett changed the title remove usage of ddtrace as DataDog stopped working remove usage of ddtrace as DataDog stopped working Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@zacharyburnett zacharyburnett force-pushed the fix/remove_ddtrace branch 2 times, most recently from eea3a09 to b142b0d Compare November 1, 2023 18:49
@zacharyburnett
Copy link
Collaborator Author

removing the --ddtrace flag from the pytest run appears to not affect the error at all... trying again without ddtrace installed at all: https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FRoman-Developers-Pull-Requests/detail/Roman-Developers-Pull-Requests/461/pipeline

@zacharyburnett
Copy link
Collaborator Author

https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FRoman-Developers-Pull-Requests/detail/Roman-Developers-Pull-Requests/461/pipeline

+ pytest -r sxf -n auto --bigdata --slow --webbpsf --cov --cov-report=xml:coverage.xml --basetemp=test_outputs --junit-xml=results.xml --dist=loadscope --env=dev
============================= test session starts ==============================
platform linux -- Python 3.11.5, pytest-7.4.3, pluggy-1.3.0
rootdir: /srv/jenkins/workspace/RT/Roman-Developers-Pull-Requests/clone
configfile: pyproject.toml
plugins: asdf-3.0.1, hypothesis-6.88.1, remotedata-0.4.1, mock-3.12.0, filter-subpackage-0.1.2, doctestplus-1.0.0, astropy-header-0.2.2, arraydiff-0.5.0, cov-4.1.0, astropy-0.11.0, ci-watson-0.6.2, romancal-0.6.1.dev518+g262244f, xdist-3.3.1, sugar-0.9.7
created: 12/12 workers
12 workers [697 items]

.s.s....................ss.............................................. [ 10%]
........................................................................ [ 20%]
........................................................................ [ 30%]
........................................................................ [ 41%]
........................................................................ [ 51%]
........................................................................ [ 61%]
.....ss................................................................. [ 72%]
........................................................................ [ 82%]
....................................F.................F................. [ 92%]
...........[gw7] node down: Not properly terminated
F
replacing crashed worker gw7
FFFFFF..................F[gw11] node down: Not properly terminated
F
replacing crashed worker gw11
[gw3] node down: Not properly terminated
F
replacing crashed worker gw3
FFF[gw13] node down: Not properly terminated
F
replacing crashed worker gw13
FFFF.[gw12] node down: Not properly terminated
F
replacing crashed worker gw12
F[gw6] node down: Not properly terminated
F
replacing crashed worker gw6
Sending interrupt signal to process
After 20s process did not stop

@schlafly
Copy link
Collaborator

schlafly commented Nov 6, 2023

This may be related to spacetelescope/stcal#226, if we think the regression tests are overloading the system or something? I may be misunderstanding.

@schlafly
Copy link
Collaborator

schlafly commented Nov 6, 2023

FWIW, I just merged spacetelescope/stcal#226, in case that helps!

@schlafly
Copy link
Collaborator

I think we can close this as the memory improvements in ramp fitting seem to have made it go away?

@zacharyburnett zacharyburnett deleted the fix/remove_ddtrace branch November 21, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants