Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include parallax correction in unit tests. #925

Closed
wants to merge 3 commits into from
Closed

Include parallax correction in unit tests. #925

wants to merge 3 commits into from

Conversation

mairanteodoro
Copy link
Collaborator

@mairanteodoro mairanteodoro commented Oct 5, 2023 •
edited
Loading

This PR adds parallax correction to the unit tests.

Since the coordinates in the catalog obtained from the VO API are now being updated for both proper motion and parallax, we also need to take that into account in the test_astrometric_utils suite.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@mairanteodoro mairanteodoro changed the title Include parallax correction to unit tests. Include parallax correction in unit tests. Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@mairanteodoro mairanteodoro marked this pull request as ready for review October 5, 2023 11:26
@mairanteodoro mairanteodoro requested a review from a team as a code owner October 5, 2023 11:26
@mairanteodoro
Copy link
Collaborator Author

This fix has been added to #919.

@mairanteodoro mairanteodoro removed request for a team, schlafly and ddavis-stsci October 5, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no-changelog-entry-needed testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mairanteodoro