-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up linting and tool configs #1547
Merged
WilliamJamieson
merged 8 commits into
spacetelescope:main
from
WilliamJamieson:mnt/clean_up_lint
Dec 16, 2024
Merged
Clean up linting and tool configs #1547
WilliamJamieson
merged 8 commits into
spacetelescope:main
from
WilliamJamieson:mnt/clean_up_lint
Dec 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamJamieson
requested review from
zacharyburnett and
braingram
and removed request for
a team
November 27, 2024 17:47
github-actions
bot
added
documentation
Improvements or additions to documentation
Dark Current
Photom
ramp_fitting
jump
testing
Saturation
linearity
pipeline
assign_wcs
dq_init
dependencies
Pull requests that update a dependency file
regression_testing
associations
Wide Field Instrument (WFI)
flatfield
labels
Nov 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1547 +/- ##
==========================================
- Coverage 78.00% 77.94% -0.06%
==========================================
Files 115 115
Lines 7555 7622 +67
==========================================
+ Hits 5893 5941 +48
- Misses 1662 1681 +19 ☔ View full report in Codecov by Sentry. |
zacharyburnett
approved these changes
Dec 2, 2024
WilliamJamieson
force-pushed
the
mnt/clean_up_lint
branch
from
December 2, 2024 16:12
fa17546
to
1b7bb57
Compare
WilliamJamieson
force-pushed
the
mnt/clean_up_lint
branch
from
December 16, 2024 15:18
1b7bb57
to
46900b9
Compare
WilliamJamieson
force-pushed
the
mnt/clean_up_lint
branch
2 times, most recently
from
December 16, 2024 16:40
0ab898e
to
3078817
Compare
WilliamJamieson
force-pushed
the
mnt/clean_up_lint
branch
from
December 16, 2024 16:44
3078817
to
d327a97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
assign_wcs
associations
Dark Current
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
dq_init
flatfield
jump
linearity
no-changelog-entry-needed
Photom
pipeline
ramp_fitting
regression_testing
Saturation
testing
Wide Field Instrument (WFI)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches to using Ruff for code formatting, import sorting, upgrading, and security checking rather than using separate tooling (these are drop in replacements). It also adds the
RUF
andB
rule sets as both of those are useful (RUF
has rules governingnoqa
marks andB
is a collection of common but difficult to debug potential issues). Finally, this cleans up the pytest config.Tasks
24Q4_B15
(use the latest build if not sure)no-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)docs/
pageokify_regtests
to update the truth filesnews fragment change types...
changes/<PR#>.general.rst
: infrastructure or miscellaneous changechanges/<PR#>.docs.rst
changes/<PR#>.stpipe.rst
changes/<PR#>.associations.rst
changes/<PR#>.scripts.rst
changes/<PR#>.mosaic_pipeline.rst
changes/<PR#>.patch_match.rst
steps
changes/<PR#>.dq_init.rst
changes/<PR#>.saturation.rst
changes/<PR#>.refpix.rst
changes/<PR#>.linearity.rst
changes/<PR#>.dark_current.rst
changes/<PR#>.jump_detection.rst
changes/<PR#>.ramp_fitting.rst
changes/<PR#>.assign_wcs.rst
changes/<PR#>.flatfield.rst
changes/<PR#>.photom.rst
changes/<PR#>.flux.rst
changes/<PR#>.source_detection.rst
changes/<PR#>.tweakreg.rst
changes/<PR#>.skymatch.rst
changes/<PR#>.outlier_detection.rst
changes/<PR#>.resample.rst
changes/<PR#>.source_catalog.rst