-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mention strun package name usage in docs #1476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1476 +/- ##
=======================================
Coverage 76.77% 76.77%
=======================================
Files 118 118
Lines 7747 7747
=======================================
Hits 5948 5948
Misses 1799 1799 ☔ View full report in Codecov by Sentry. |
81d8b05
to
f79f88b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
f79f88b
to
070feab
Compare
I brought this out of draft since now stpipe main has changes (spacetelescope/stpipe#195) useful to romancal. I updated this PR to point to stpipe main and started regtests here: |
Regtests all passed so merging. |
Following spacetelescope/stpipe#202 stpipe allows providing a package name to resolve ambiguous aliases provided to strun:
This PR adds a note to the docs about when this might be needed.
Link to docs (note is at the end of this section): https://roman-pipeline--1476.org.readthedocs.build/en/1476/roman/pipeline_run.html#from-the-command-line
As the current stpipe required version doesn't support this I'll leave this PR as draft but request reviews for comments on the wording.
This PR makes no code changes so regression tests were not run.
Tasks
24Q4_B15
(use the latest build if not sure)no-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)docs/
pageokify_regtests
to update the truth filesnews fragment change types...
changes/<PR#>.general.rst
: infrastructure or miscellaneous changechanges/<PR#>.docs.rst
changes/<PR#>.stpipe.rst
changes/<PR#>.associations.rst
changes/<PR#>.scripts.rst
changes/<PR#>.mosaic_pipeline.rst
changes/<PR#>.patch_match.rst
steps
changes/<PR#>.dq_init.rst
changes/<PR#>.saturation.rst
changes/<PR#>.refpix.rst
changes/<PR#>.linearity.rst
changes/<PR#>.dark_current.rst
changes/<PR#>.jump_detection.rst
changes/<PR#>.ramp_fitting.rst
changes/<PR#>.assign_wcs.rst
changes/<PR#>.flatfield.rst
changes/<PR#>.photom.rst
changes/<PR#>.flux.rst
changes/<PR#>.source_detection.rst
changes/<PR#>.tweakreg.rst
changes/<PR#>.skymatch.rst
changes/<PR#>.outlier_detection.rst
changes/<PR#>.resample.rst
changes/<PR#>.source_catalog.rst