Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore addressed attrs deprecation warning in oldestdeps #371

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Aug 5, 2024

The newest version of attrs includes a deprecation warning for a feature used in asdf:
https://github.com/python-attrs/attrs/releases/tag/24.1.0
This has been addressed:
asdf-format/asdf#1815
and released in asdf 3.4.0
https://github.com/asdf-format/asdf/releases/tag/3.4.0

However the oldestdeps job here will not pick up the change until the minimum asdf version is 3.4.0. This is because the oldest deps job only installs the oldest versions of direct dependencies (like asdf) and will install the newest version of indirect deps (like attrs).

This PR adds a warning filter to ignore the warning from attrs.

Checklist

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.66%. Comparing base (087a60d) to head (f167029).
Report is 63 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
+ Coverage   97.56%   97.66%   +0.10%     
==========================================
  Files          30       36       +6     
  Lines        2788     3335     +547     
==========================================
+ Hits         2720     3257     +537     
- Misses         68       78      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review August 5, 2024 19:50
@braingram braingram requested a review from a team as a code owner August 5, 2024 19:50
@braingram braingram requested a review from PaulHuwe August 5, 2024 19:50
@braingram braingram mentioned this pull request Aug 5, 2024
4 tasks
Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@braingram braingram merged commit 317bb84 into spacetelescope:main Aug 6, 2024
16 of 17 checks passed
@braingram braingram deleted the attrs_dep branch August 6, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants