-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace usages of copy_arrays
with memmap
#360
replace usages of copy_arrays
with memmap
#360
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
- Coverage 97.56% 97.20% -0.36%
==========================================
Files 30 37 +7
Lines 2788 3359 +571
==========================================
+ Hits 2720 3265 +545
- Misses 68 94 +26 ☔ View full report in Codecov by Sentry. |
Bumping the asdf version to at least 3.1.0 should fix the oldest deps: roman_datamodels/pyproject.toml Line 16 in 1b298e1
|
Can you please add a RCAL regression test URL as well? |
RCAL regtest running at https://github.com/spacetelescope/RegressionTests/actions/runs/10042547798 with this branch installed |
a few failures in RCAL regtests: https://github.com/spacetelescope/RegressionTests/actions/runs/10042547798/attempts/2#summary-27759909972 |
0a25d81
to
086ab4b
Compare
The failures are unrelated (they're expected and caused by spacetelescope/romancal#1241). Would you re-run them? I okified the results from a different run but I think that wasn't until after your tests had run. |
sure, rerunning here: https://github.com/spacetelescope/RegressionTests/actions/runs/10042547798 |
The oldest deps failure should be solvable with a bump to the gwcs version: |
Sorry for the back and forth but this will likely need another run. It turns out that some of the roman tests continue to fail after the first "okify": spacetelescope/romancal#1325 I have a run on main to test if the current "okified" results pass. I'll post and update here once the run on main passes. |
I re-ran the regtests for this PR (now that the romancal main ones are passing): The run with this PR shows all passing tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
follow-on to asdf-format/asdf#1797
Checklist
CHANGES.rst
under the corresponding subsection